Skip to content

gh-136447: Use self.loop instead of global loop variable in asyncio REPL#136448

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
injust:patch-1
Jul 9, 2025
Merged

gh-136447: Use self.loop instead of global loop variable in asyncio REPL#136448
kumaraditya303 merged 1 commit into
python:mainfrom
injust:patch-1

Conversation

@injust

@injust injust commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

loop is passed to AsyncIOInteractiveConsole and assigned to the instance attribute self.loop.

This PR fixes the one place where AsyncIOInteractiveConsole uses the global loop variable instead of self.loop.

@python-cla-bot

python-cla-bot Bot commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jul 9, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 9, 2025
Closed
@kumaraditya303 kumaraditya303 merged commit 77fa7a4 into python:main Jul 9, 2025
49 checks passed
@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 9, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 9, 2025

Copy link
Copy Markdown

Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 9, 2025

Copy link
Copy Markdown

Thanks @injust for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@injust @miss-islington
pythongh-136447: Use self.loop instead of global loop variable in…
7fcbe06 
… asyncio REPL (pythonGH-136448)

(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 9, 2025

Copy link
Copy Markdown

GH-136457 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@injust @miss-islington
pythongh-136447: Use self.loop instead of global loop variable in…
441b440 
… asyncio REPL (pythonGH-136448)

(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2025
@bedevere-app

bedevere-app Bot commented Jul 9, 2025

Copy link
Copy Markdown

GH-136458 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @injust
[3.13] gh-136447: Use self.loop instead of global loop variable i…
532ecac 
…n asyncio REPL (GH-136448) (#136457)

gh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (GH-136448)
(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @injust
[3.14] gh-136447: Use self.loop instead of global loop variable i…
19518a4 
…n asyncio REPL (GH-136448) (#136458)

gh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (GH-136448)
(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@injust @AndPuQing
pythongh-136447: Use self.loop instead of global loop variable in…
795dd84 
… asyncio REPL (python#136448)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@injust @Pranjal095
pythongh-136447: Use self.loop instead of global loop variable in…
f1b1766 
… asyncio REPL (python#136448)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@injust @picnixz
pythongh-136447: Use self.loop instead of global loop variable in…
2149d3f 
… asyncio REPL (python#136448)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@injust @taegyunkim
pythongh-136447: Use self.loop instead of global loop variable in…
34f1bd9 
… asyncio REPL (python#136448)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@injust @Agent-Hellboy
pythongh-136447: Use self.loop instead of global loop variable in…
79c21e1 
… asyncio REPL (python#136448)
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @injust @kumaraditya303
[3.14] pythongh-136447: Use self.loop instead of global loop vari…
7ddcc99 
…able in asyncio REPL (pythonGH-136448) (python#136458)

pythongh-136447: Use `self.loop` instead of global `loop` variable in asyncio REPL (pythonGH-136448)
(cherry picked from commit 77fa7a4)

Co-authored-by: Justin Su <injustsu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@injust @kumaraditya303